G40 Redesign (currently taking suggestions)

@waxfingers ahh…ok So it does work then ? You just wanna add as a Map option ?

@barnee

There might be some redundant code in there though as BM had things where they had conditions for 1, 2, or 3 count of units. I just replicated that so like there might be a place 2 battleship, condition and trigger when really that can go now that I think of it.

@barnee

Correct, if you throw it in I believe the code is stand alone. There might have been the odd one that also borrowed BM coding (like is Vichy active).

@waxfingers ok well if you want, you can fork the House Rules Mod at Git and then do a PR and I can add it that way. Are you familiar with adding it as a Map Option ? If not just do some searches for game property.

I added some things by using tech too, so some are different.

If that’s more than your comfortable with right now, I can look at it later, but it seems that you got it working already. I guess just put it at the end of the French Triggers.

The xml is kinda sloppy. I was just figuring stuff out when I started it, so stuffs a little all over the place lol

Here’s a Map Option example in case you’re not familiar with them.

<attachment name=“MovelVCs” attachTo=“Germans” javaClass=“games.strategy.triplea.attachments.RulesAttachment” type=“player”>
<option name=“gameProperty” value=“Movel Victory Conditions”/>
</attachment>

<attachment name=“conditionAttachmentTurn11CheckVCMovel” attachTo=“Germans” javaClass=“games.strategy.triplea.attachments.RulesAttachment” type=“player”>
<option name=“conditions” value=“MovelVCs:conditionAttachmentTurn11CheckVC”/>
<option name=“conditionType” value=“AND”/>
</attachment>
<attachment name=“triggerAttachment11note” attachTo=“Germans” javaClass=“games.strategy.triplea.attachments.TriggerAttachment” type=“player”>

  <option name="trigger" value="conditionAttachmentTurn11CheckVCMovel"/>
  <option name="notification" value="R011VC"/>
  <option name="uses" value="1"/>
  <option name="when" value="before:germansPurchase"/>
</attachment>

<property name=“Movel Victory Conditions” value=“false” editable=“true”>
<boolean/>
</property>

So “MovelVCs” becomes the condition that you add to your trigger(s) . That way they will only fire if you turn it on in map options

Probably just call it “French Battleship Sea Zone 92” or something. Then abbreviate it however you want for the condition.

Just stick it below the Movel one and put the triggers at the end of France. There may be more than one set of French triggers with the Vichy stuff added. Shouldn’t matter as long as the condition comes first

@barnee

Ideas:

• 1. BB in SZ 92, added with Vichy Rules.
• 2. Fleet Carriers and Battleships upgraded from their respective Hulls (2 build phases). Escort Carriers added as 1 Build turn.
• 3. AA on Battleships and Cruisers.
• 4. Rail and trains.
• 5. Surprise Attack tokens and areas (like Kamikaze but for attacks).

Details:

1. Explained in earlier post.
   Working and complete.

2. Fleet Carriers (new name for old unit) and Battleships require 2 build phases and are upgraded from their respective hulls (or single hull is fine like TWW). Escort Carriers added as A0 D2 M1 1Hitpoint 1 Plane spot 1 Build turn to accommodate 1 turn panic defense or plane landings.
   Idea complete, coding for hulls built on land then launched not complete. Known coding for sea unit hulls.

3. Battleships and Cruisers both have 2 dice rolls at 1/6. Might make Cruisers a bit more attractive as it would thus cost 24 PUs (2 Cruisers) for 4 dice, vs 20 PUs (1 Battleship) for 2 dice.
   I see that there is already an AA option though so I can try that out and see how it goes with current stats.

4. Work in progress for stats, etc, but initial thoughts are: Rail would be a condition to move trains (TWW has this working). Rail acts just like harbours and airbases (15 PUs, bombed to 6, works at 2, placed as infrastructure - no restrictions). Trains move 3 spaces and only into territory that was owned at start of round and in non combat. Carrying capacity is 35 (when alone 7 inf, 8 marines, 6 mech units based on their current load values). My idea is to keep a train unit price high and high capacity so that it does not bog the game down too much and make too many possibilities. Basically it might be used to zip Russian pacific guys to Moscow, or Ukraine to Moscow, or Germany to Normandy or to Russian front. By having too many trains then too much stuff could change in the game (unless someone really wants to pay for it). Not sure yet if trains would be purchasable (TWW) or like Expansion mod where you get given a certain amount.
   Idea in progress. Transport coding not working. TWW has working coding.

5. Not sure if this would be for first attacks between countries, after declaring war only, or just special places that it could be done anytime. Requires token symbol to be in territory. All of these surprise attack areas (I have a few others - still researching history) would let the attacker choose a target for each die like the Kamikaze pop up window.
   For example:

• Taranto SZ 97 (British tokens - air)
• Pearl Harbour SZ (Japanese tokens - air)
• Belarus (Russian aircraft/airfield bombings from initial German air attacks) (German tokens - air)
• Eastern Poland (battle of Brody) (German tokens - air/tanks)
• Rostov for Russian raid on Tatsinskaya (Russian tokens - tanks)
• Midway SZ (USA Tokens - air)
• Battle of the Bulge, Belgium - (German tokens - tanks, USA tokens - tanks)
  Maybe make it simple and be exactly like Kamikaze tokens that can be used whenever. Perhaps the symbols could be split into different battle types, with a condition of at least 3 tanks or 3 planes (respectively) being used for the attack, or perhaps units that are related to the specific battle and have a condition for which country. I think a 4 die roll each to make it actually get the chance of a BB or carrier kill. How many owned per country that has them, thinking 3 (guaranteed 2 hits with LL). This would create tension and extra carefulness about what is put in these areas for defense at least until the tokens have been used.
  Could not find a way to replicate Kamikaze coding.

@barnee

Sorry, I don’t know what you mean by forking House Rules Mod at Git and then doing a PR or what I would be doing anyways. What I have been doing is pulling the game file from my downloadedmaps files and then modifying them.

I looked for some threads about game properties and have come across one. Also thanks for your example, I see the similarities between both examples.

I literally started this a week ago and it is the first time I have looked at XML. I am using MS Notepad and just looking for scenarios, units, and such in the existing code that is similar to what I want to do. Then copying it and tweaking for my ideas.

Anyways, I will plug the option rule into the House Rules game file and see how it works.

Hi @barnee

I got the option game property check box for the French BB into the House Rules game code and all working based on the condition that Vichy Rules are also in play.

Do you want me to send you the additions?

@barnee

The only thing that looks out of place is the Neutral Axis units have a bluish shade to them in your House Rules map but only for the units that were already on the map (destroyer, cruiser, infantry, art). I don’t have the capability to edit these units. Are you able to add the bluish color to the battleship and hit battleship units?

@barnee

Here is the code and where to put it into the game file if you can:

I put the game property option just after BM Vichy Rule since it would go hand in hand with that.

<property name="BM Vichy Rule" value="false" editable="true">
  <boolean/>
</property>
<property name="French Battleship Sea Zone 92" value="false" editable="true">
  <boolean/>
</property>

I put this at the end of French triggers:

<attachment name="French_BB_SZ_92_Option" attachTo="Changer" javaClass="games.strategy.triplea.attachments.RulesAttachment" type="player">
  <option name="gameProperty" value="French Battleship Sea Zone 92"/>
</attachment>
<attachment name="conditionAttachmentVichyCheckFrenchBBSZ92" attachTo="Changer" javaClass="games.strategy.triplea.attachments.RulesAttachment" type="player">
  <option name="conditions" value="French_BB_SZ_92_Option:Vichy"/>
  <option name="conditionType" value="AND"/>
</attachment>
<attachment name="triggerAttachment_Place_French_BB_SZ_92" attachTo="French" javaClass="games.strategy.triplea.attachments.TriggerAttachment" type="player">
  <option name="trigger" value="conditionAttachmentVichyCheckFrenchBBSZ92"/>
  <option name="placement" value="92 Sea Zone:battleship"/>
  <option name="uses" value="1"/>
  <option name="when" value="after:gameInitDelegate"/>
</attachment>

Here is the code for the battleship scenarios. I put it between the <!-- Vichy Fleet --> and the <!-- Vichy Morocco --> code. So pasting above/before the Vichy Morocco code.

<!-- Vichy Mers-el-Kebir Fleet -->
<attachment name="conditionAttachment_92_Sea_Zone_No_British_Units_1" attachTo="British" javaClass="games.strategy.triplea.attachments.RulesAttachment" type="player">
  <option name="directPresenceTerritories" value="1:92 Sea Zone"/>
  <option name="unitPresence" value="1:submarine:destroyer:cruiser:battleship:carrier"/>
  <option name="invert" value="true"/>
</attachment>
<attachment name="conditionAttachment_92_Sea_Zone_No_American_Units_1" attachTo="Americans" javaClass="games.strategy.triplea.attachments.RulesAttachment" type="player">
  <option name="directPresenceTerritories" value="1:92 Sea Zone"/>
  <option name="unitPresence" value="1:submarine:destroyer:cruiser:battleship:carrier"/>
  <option name="invert" value="true"/>
</attachment>
<attachment name="conditionAttachment_92_Sea_Zone_No_Russian_Units_1" attachTo="Russians" javaClass="games.strategy.triplea.attachments.RulesAttachment" type="player">
  <option name="directPresenceTerritories" value="1:92 Sea Zone"/>
  <option name="unitPresence" value="1:submarine:destroyer:cruiser:battleship:carrier"/>
  <option name="invert" value="true"/>
</attachment>
<attachment name="conditionAttachment_92_Sea_Zone_No_ANZAC_Units_1" attachTo="ANZAC" javaClass="games.strategy.triplea.attachments.RulesAttachment" type="player">
  <option name="directPresenceTerritories" value="1:92 Sea Zone"/>
  <option name="unitPresence" value="1:submarine:destroyer:cruiser:battleship:carrier"/>
  <option name="invert" value="true"/>
</attachment>
<attachment name="conditionAttachment_No_Allied_Units_In_92_Sea_Zone" attachTo="French" javaClass="games.strategy.triplea.attachments.RulesAttachment" type="player">
  <option name="conditions" value="conditionAttachment_92_Sea_Zone_No_British_Units_1:conditionAttachment_92_Sea_Zone_No_American_Units_1:conditionAttachment_92_Sea_Zone_No_ANZAC_Units_1:conditionAttachment_92_Sea_Zone_No_Russian_Units_1"/>
</attachment>
<attachment name="conditionAttachment_Yes_Allied_Units_In_92_Sea_Zone" attachTo="French" javaClass="games.strategy.triplea.attachments.RulesAttachment" type="player">
  <option name="conditions" value="conditionAttachment_No_Allied_Units_In_92_Sea_Zone"/>
  <option name="invert" value="true"/>
</attachment>  
<attachment name="conditionAttachment_Fleet_Can_Turn_Vichy_Battleship" attachTo="French" javaClass="games.strategy.triplea.attachments.RulesAttachment" type="player">
  <option name="directPresenceTerritories" value="92 Sea Zone" count="1"/>
  <option name="unitPresence" value="battleship" count="1"/>
</attachment>
<attachment name="conditionAttachment_Fleet_Can_Turn_Vichy_Battleship_2" attachTo="French" javaClass="games.strategy.triplea.attachments.RulesAttachment" type="player">
  <option name="directPresenceTerritories" value="92 Sea Zone" count="1"/>
  <option name="unitPresence" value="battleship" count="2"/>
</attachment>
<attachment name="triggerAttachment_Axis_Conquer_All_France_Battleship_Remove" attachTo="French" javaClass="games.strategy.triplea.attachments.TriggerAttachment" type="player">
  <option name="conditions" value="conditionAttachment_False"/>
  <option name="removeUnits" value="92 Sea Zone:battleship"/>
  <option name="when" value="after:frenchPolitics"/>
</attachment>
<attachment name="triggerAttachment_Axis_Conquer_All_France_Battleship_Place" attachTo="Neutral_Axis" javaClass="games.strategy.triplea.attachments.TriggerAttachment" type="player">
  <option name="conditions" value="conditionAttachment_No_Allied_Units_In_92_Sea_Zone:conditionAttachment_Axis_Conquer_All_France:conditionAttachment_French_Territory_May_Turn_Vichy_Switch:conditionAttachment_No_Allied_Units_In_Southern_France:conditionAttachment_Fleet_Can_Turn_Vichy_Battleship"/>
  <option name="placement" value="92 Sea Zone:battleship"/>
  <option name="when" value="after:frenchPolitics"/>
  <option name="uses" value="1"/>
  <option name="activateTrigger" value="triggerAttachment_Axis_Conquer_All_France_Battleship_Remove:1:true:true:false:false"/>
</attachment>
<attachment name="triggerAttachment_Axis_Conquer_All_France_Battleship_Sunk" attachTo="Neutral_Axis" javaClass="games.strategy.triplea.attachments.TriggerAttachment" type="player">
  <option name="conditions" value="conditionAttachment_Yes_Allied_Units_In_92_Sea_Zone:conditionAttachment_Axis_Conquer_All_France:conditionAttachment_French_Territory_May_Turn_Vichy_Switch:conditionAttachment_No_Allied_Units_In_Southern_France:conditionAttachment_Fleet_Can_Turn_Vichy_Battleship"/>
  <option name="placement" value="87 Sea Zone:battleship"/>
  <option name="when" value="after:frenchPolitics"/>
  <option name="uses" value="1"/>
  <option name="activateTrigger" value="triggerAttachment_Axis_Conquer_All_France_Battleship_Remove:1:true:true:false:false"/>
</attachment>
<attachment name="triggerAttachment_Axis_Conquer_All_France_Battleship_Place_2" attachTo="Neutral_Axis" javaClass="games.strategy.triplea.attachments.TriggerAttachment" type="player">
  <option name="conditions" value="conditionAttachment_No_Allied_Units_In_92_Sea_Zone:conditionAttachment_Axis_Conquer_All_France:conditionAttachment_French_Territory_May_Turn_Vichy_Switch:conditionAttachment_No_Allied_Units_In_Southern_France:conditionAttachment_Fleet_Can_Turn_Vichy_Battleship_2"/>
  <option name="placement" value="92 Sea Zone:battleship"/>
  <option name="when" value="after:frenchPolitics"/>
  <option name="uses" value="1"/>
  <option name="activateTrigger" value="triggerAttachment_Axis_Conquer_All_France_Battleship_Remove:1:true:true:false:false"/>
</attachment>
<attachment name="triggerAttachment_Axis_Conquer_All_France_Battleship_Sunk_2" attachTo="Neutral_Axis" javaClass="games.strategy.triplea.attachments.TriggerAttachment" type="player">
  <option name="conditions" value="conditionAttachment_Yes_Allied_Units_In_92_Sea_Zone:conditionAttachment_Axis_Conquer_All_France:conditionAttachment_French_Territory_May_Turn_Vichy_Switch:conditionAttachment_No_Allied_Units_In_Southern_France:conditionAttachment_Fleet_Can_Turn_Vichy_Battleship_2"/>
  <option name="placement" value="87 Sea Zone:battleship"/>
  <option name="when" value="after:frenchPolitics"/>
  <option name="uses" value="1"/>
  <option name="activateTrigger" value="triggerAttachment_Axis_Conquer_All_France_Battleship_Remove:1:true:true:false:false"/>
</attachment>
<!-- Vichy Dakar Port Fleet & French West Africa -->
<attachment name="conditionAttachment_Algeria_No_British_Units_1" attachTo="British" javaClass="games.strategy.triplea.attachments.RulesAttachment" type="player">
  <option name="directPresenceTerritories" value="1:Algeria"/>
  <option name="unitPresence" value="1:infantry:artillery:mech_infantry:armour:aaGun:marine"/>
  <option name="invert" value="true"/>
</attachment>
<attachment name="conditionAttachment_Algeria_No_American_Units_1" attachTo="Americans" javaClass="games.strategy.triplea.attachments.RulesAttachment" type="player">
  <option name="directPresenceTerritories" value="1:Algeria"/>
  <option name="unitPresence" value="1:infantry:artillery:mech_infantry:armour:aaGun:marine"/>
  <option name="invert" value="true"/>
</attachment>
<attachment name="conditionAttachment_Algeria_No_Russian_Units_1" attachTo="Russians" javaClass="games.strategy.triplea.attachments.RulesAttachment" type="player">
  <option name="directPresenceTerritories" value="1:Algeria"/>
  <option name="unitPresence" value="1:infantry:artillery:mech_infantry:armour:aaGun:marine"/>
  <option name="invert" value="true"/>
</attachment>
<attachment name="conditionAttachment_Algeria_No_ANZAC_Units_1" attachTo="ANZAC" javaClass="games.strategy.triplea.attachments.RulesAttachment" type="player">
  <option name="directPresenceTerritories" value="1:Algeria"/>
  <option name="unitPresence" value="1:infantry:artillery:mech_infantry:armour:aaGun:marine"/>
  <option name="invert" value="true"/>
</attachment>
<attachment name="conditionAttachment_No_Allied_Units_In_Algeria" attachTo="French" javaClass="games.strategy.triplea.attachments.RulesAttachment" type="player">
  <option name="conditions" value="conditionAttachment_Algeria_No_British_Units_1:conditionAttachment_Algeria_No_American_Units_1:conditionAttachment_Algeria_No_ANZAC_Units_1:conditionAttachment_Algeria_No_Russian_Units_1"/>
</attachment>
<attachment name="conditionAttachment_Algeria_No_German_Units_1" attachTo="Germans" javaClass="games.strategy.triplea.attachments.RulesAttachment" type="player">
  <option name="directPresenceTerritories" value="1:Algeria"/>
  <option name="unitPresence" value="1:infantry:artillery:mech_infantry:armour:aaGun:marine"/>
  <option name="invert" value="true"/>
</attachment>
<attachment name="conditionAttachment_Algeria_No_Italian_Units_1" attachTo="Italians" javaClass="games.strategy.triplea.attachments.RulesAttachment" type="player">
  <option name="directPresenceTerritories" value="1:Algeria"/>
  <option name="unitPresence" value="1:infantry:artillery:mech_infantry:armour:aaGun:marine"/>
  <option name="invert" value="true"/>
</attachment>
<attachment name="conditionAttachment_Algeria_No_Japanese_Units_1" attachTo="Japanese" javaClass="games.strategy.triplea.attachments.RulesAttachment" type="player">
  <option name="directPresenceTerritories" value="1:Algeria"/>
  <option name="unitPresence" value="1:infantry:artillery:mech_infantry:armour:aaGun:marine"/>
  <option name="invert" value="true"/>
</attachment>
<attachment name="conditionAttachment_No_Axis_Units_In_Algeria" attachTo="French" javaClass="games.strategy.triplea.attachments.RulesAttachment" type="player">
  <option name="conditions" value="conditionAttachment_Algeria_No_German_Units_1:conditionAttachment_Algeria_No_Italian_Units_1:conditionAttachment_Algeria_No_Japanese_Units_1"/>
</attachment>
<attachment name="conditionAttachment_Yes_Axis_Units_In_Algeria" attachTo="French" javaClass="games.strategy.triplea.attachments.RulesAttachment" type="player">
  <option name="conditions" value="conditionAttachment_No_Axis_Units_In_Algeria"/>
  <option name="invert" value="true"/>
</attachment>  
<attachment name="conditionAttachment_Southern_France_No_German_Units_1" attachTo="Germans" javaClass="games.strategy.triplea.attachments.RulesAttachment" type="player">
  <option name="directPresenceTerritories" value="1:Southern France"/>
  <option name="unitPresence" value="1:infantry:artillery:mech_infantry:armour:aaGun:marine"/>
  <option name="invert" value="true"/>
</attachment>
<attachment name="conditionAttachment_Southern_France_No_Italian_Units_1" attachTo="Italians" javaClass="games.strategy.triplea.attachments.RulesAttachment" type="player">
  <option name="directPresenceTerritories" value="1:Southern France"/>
  <option name="unitPresence" value="1:infantry:artillery:mech_infantry:armour:aaGun:marine"/>
  <option name="invert" value="true"/>
</attachment>
<attachment name="conditionAttachment_Southern_France_No_Japanese_Units_1" attachTo="Japanese" javaClass="games.strategy.triplea.attachments.RulesAttachment" type="player">
  <option name="directPresenceTerritories" value="1:Southern France"/>
  <option name="unitPresence" value="1:infantry:artillery:mech_infantry:armour:aaGun:marine"/>
  <option name="invert" value="true"/>
</attachment>
<attachment name="conditionAttachment_No_Axis_Units_In_Southern_France" attachTo="French" javaClass="games.strategy.triplea.attachments.RulesAttachment" type="player">
  <option name="conditions" value="conditionAttachment_Southern_France_No_German_Units_1:conditionAttachment_Southern_France_No_Italian_Units_1:conditionAttachment_Southern_France_No_Japanese_Units_1"/>
</attachment>
<attachment name="conditionAttachment_Yes_Axis_Units_In_Southern_France" attachTo="French" javaClass="games.strategy.triplea.attachments.RulesAttachment" type="player">
  <option name="conditions" value="conditionAttachment_No_Axis_Units_In_Southern_France"/>
  <option name="invert" value="true"/>
</attachment>  
<attachment name="conditionAttachment_French_West_Africa_Vichy_Controlled" attachTo="Neutral_Axis" javaClass="games.strategy.triplea.attachments.RulesAttachment" type="player">
  <option name="directOwnershipTerritories" value="French West Africa" count="1"/>
</attachment>
<attachment name="conditionAttachment_Fleet_Can_Turn_Neutral_Allies_Battleship" attachTo="Neutral_Axis" javaClass="games.strategy.triplea.attachments.RulesAttachment" type="player">
  <option name="directPresenceTerritories" value="92 Sea Zone" count="1"/>
  <option name="unitPresence" value="battleship" count="1"/>
</attachment>
<attachment name="conditionAttachment_Axis_Occupy_Algeria" attachTo="French" javaClass="games.strategy.triplea.attachments.RulesAttachment" type="player">
  <option name="conditions" value="conditionAttachment_No_Allied_Units_In_Algeria:conditionAttachment_Yes_Axis_Units_In_Algeria"/>
  <option name="conditionType" value="AND"/>
</attachment>
<attachment name="conditionAttachment_French_West_Africa_Can_Turn_Neutral_Allies" attachTo="French" javaClass="games.strategy.triplea.attachments.RulesAttachment" type="player">
  <option name="conditions" value="conditionAttachment_Axis_Occupy_Algeria:conditionAttachment_French_West_Africa_Vichy_Controlled:conditionAttachment_Fleet_Can_Turn_Neutral_Allies_Battleship:conditionAttachment_No_Axis_Units_In_Southern_France"/>
  <option name="conditionType" value="AND"/>
</attachment>
<attachment name="conditionAttachment_French_West_Africa_Can_Turn_Neutral_Allies_Infantry" attachTo="Neutral_Axis" javaClass="games.strategy.triplea.attachments.RulesAttachment" type="player">
  <option name="directPresenceTerritories" value="French West Africa" count="1"/>
  <option name="unitPresence" value="infantry" count="1"/>
</attachment>
<attachment name="triggerAttachment_Italy_Occupies_Algeria_Infantry_Remove" attachTo="Neutral_Axis" javaClass="games.strategy.triplea.attachments.TriggerAttachment" type="player">
  <option name="conditions" value="conditionAttachment_False"/>
  <option name="removeUnits" value="French West Africa:infantry"/>
  <option name="when" value="after:italiansNonCombatMove"/>
</attachment>
<attachment name="triggerAttachment_Italy_Occupies_Algeria_Infantry_Place" attachTo="Neutral_Allies" javaClass="games.strategy.triplea.attachments.TriggerAttachment" type="player">
  <option name="conditions" value="conditionAttachment_French_West_Africa_Can_Turn_Neutral_Allies"/>
  <option name="placement" value="French West Africa:infantry"/>
  <option name="when" value="after:italiansNonCombatMove"/>
  <option name="uses" value="1"/>
  <option name="activateTrigger" value="triggerAttachment_Italy_Occupies_Algeria_Infantry_Remove:1:true:true:false:false"/>
</attachment>
<attachment name="triggerAttachment_Italy_Occupies_Algeria_Battleship_Remove" attachTo="Neutral_Axis" javaClass="games.strategy.triplea.attachments.TriggerAttachment" type="player">
  <option name="conditions" value="conditionAttachment_False"/>
  <option name="removeUnits" value="92 Sea Zone:battleship"/>
  <option name="when" value="after:italiansNonCombatMove"/>
</attachment>
<attachment name="triggerAttachment_Italy_Occupies_Algeria_Battleship_Neutral_Allies_Place" attachTo="Neutral_Allies" javaClass="games.strategy.triplea.attachments.TriggerAttachment" type="player">
  <option name="conditions" value="conditionAttachment_French_West_Africa_Can_Turn_Neutral_Allies"/>
  <option name="placement" value="87 Sea Zone:battleship"/>
  <option name="when" value="after:italiansNonCombatMove"/>
  <option name="uses" value="1"/>
  <option name="activateTrigger" value="triggerAttachment_Italy_Occupies_Algeria_Battleship_Remove:1:true:true:false:false"/>
</attachment>
<attachment name="triggerAttachment_Germany_Occupies_Algeria_Infantry_Remove" attachTo="Neutral_Axis" javaClass="games.strategy.triplea.attachments.TriggerAttachment" type="player">
  <option name="conditions" value="conditionAttachment_False"/>
  <option name="removeUnits" value="French West Africa:infantry"/>
  <option name="when" value="after:germansNonCombatMove"/>
</attachment>
<attachment name="triggerAttachment_Germany_Occupies_Algeria_Infantry_Place" attachTo="Neutral_Allies" javaClass="games.strategy.triplea.attachments.TriggerAttachment" type="player">
  <option name="conditions" value="conditionAttachment_French_West_Africa_Can_Turn_Neutral_Allies"/>
  <option name="placement" value="French West Africa:infantry"/>
  <option name="when" value="after:germansNonCombatMove"/>
  <option name="uses" value="1"/>
  <option name="activateTrigger" value="triggerAttachment_Germany_Occupies_Algeria_Infantry_Remove:1:true:true:false:false"/>
</attachment>
<attachment name="triggerAttachment_Germany_Occupies_Algeria_Battleship_Remove" attachTo="Neutral_Axis" javaClass="games.strategy.triplea.attachments.TriggerAttachment" type="player">
  <option name="conditions" value="conditionAttachment_False"/>
  <option name="removeUnits" value="92 Sea Zone:battleship"/>
  <option name="when" value="after:germansNonCombatMove"/>
</attachment>
<attachment name="triggerAttachment_Germany_Occupies_Algeria_Battleship_Neutral_Allies_Place" attachTo="Neutral_Allies" javaClass="games.strategy.triplea.attachments.TriggerAttachment" type="player">
  <option name="conditions" value="conditionAttachment_French_West_Africa_Can_Turn_Neutral_Allies"/>
  <option name="placement" value="87 Sea Zone:battleship"/>
  <option name="when" value="after:germansNonCombatMove"/>
  <option name="uses" value="1"/>
  <option name="activateTrigger" value="triggerAttachment_Germany_Occupies_Algeria_Battleship_Remove:1:true:true:false:false"/>
</attachment>
<attachment name="triggerAttachment_Italy_Occupies_Southern_France_Battleship_FWA_Infantry_Remove" attachTo="Neutral_Axis" javaClass="games.strategy.triplea.attachments.TriggerAttachment" type="player">
  <option name="conditions" value="conditionAttachment_False"/>
  <option name="removeUnits" value="French West Africa:infantry"/>
  <option name="when" value="after:italiansNonCombatMove"/>
</attachment>
<attachment name="triggerAttachment_Italy_Occupies_Southern_France_Battleship_FWA_Infantry_Place" attachTo="Neutral_Allies" javaClass="games.strategy.triplea.attachments.TriggerAttachment" type="player">
  <option name="conditions" value="conditionAttachment_French_West_Africa_Vichy_Controlled:conditionAttachment_Fleet_Can_Turn_Neutral_Allies_Battleship:conditionAttachment_Yes_Axis_Units_In_Southern_France"/>
  <option name="placement" value="French West Africa:infantry"/>
  <option name="when" value="after:italiansNonCombatMove"/>
  <option name="uses" value="1"/>
  <option name="activateTrigger" value="triggerAttachment_Italy_Occupies_Southern_France_Battleship_FWA_Infantry_Remove:1:true:true:false:false"/>
</attachment>
<attachment name="triggerAttachment_Italy_Occupies_Southern_France_Battleship_FWA_Battleship_Remove" attachTo="Neutral_Axis" javaClass="games.strategy.triplea.attachments.TriggerAttachment" type="player">
  <option name="conditions" value="conditionAttachment_False"/>
  <option name="removeUnits" value="92 Sea Zone:battleship"/>
  <option name="when" value="after:italiansNonCombatMove"/>
</attachment>
<attachment name="triggerAttachment_Italy_Occupies_Southern_France_Battleship_FWA_Battleship_Neutral_Allies_Place" attachTo="Neutral_Allies" javaClass="games.strategy.triplea.attachments.TriggerAttachment" type="player">
  <option name="conditions" value="conditionAttachment_French_West_Africa_Vichy_Controlled:conditionAttachment_Fleet_Can_Turn_Neutral_Allies_Battleship:conditionAttachment_Yes_Axis_Units_In_Southern_France"/>
  <option name="placement" value="87 Sea Zone:battleship"/>
  <option name="when" value="after:italiansNonCombatMove"/>
  <option name="uses" value="1"/>
  <option name="activateTrigger" value="triggerAttachment_Italy_Occupies_Southern_France_Battleship_FWA_Battleship_Remove:1:true:true:false:false"/>
</attachment>
<attachment name="triggerAttachment_Germany_Occupies_Southern_France_Battleship_FWA_Infantry_Remove" attachTo="Neutral_Axis" javaClass="games.strategy.triplea.attachments.TriggerAttachment" type="player">
  <option name="conditions" value="conditionAttachment_False"/>
  <option name="removeUnits" value="French West Africa:infantry"/>
  <option name="when" value="after:germansNonCombatMove"/>
</attachment>
<attachment name="triggerAttachment_Germany_Occupies_Southern_France_Battleship_FWA_Infantry_Place" attachTo="Neutral_Allies" javaClass="games.strategy.triplea.attachments.TriggerAttachment" type="player">
  <option name="conditions" value="conditionAttachment_French_West_Africa_Vichy_Controlled:conditionAttachment_Fleet_Can_Turn_Neutral_Allies_Battleship:conditionAttachment_Yes_Axis_Units_In_Southern_France"/>
  <option name="placement" value="French West Africa:infantry"/>
  <option name="when" value="after:germansNonCombatMove"/>
  <option name="uses" value="1"/>
  <option name="activateTrigger" value="triggerAttachment_Germany_Occupies_Southern_France_Battleship_FWA_Infantry_Remove:1:true:true:false:false"/>
</attachment>
<attachment name="triggerAttachment_Germany_Occupies_Southern_France_Battleship_FWA_Battleship_Remove" attachTo="Neutral_Axis" javaClass="games.strategy.triplea.attachments.TriggerAttachment" type="player">
  <option name="conditions" value="conditionAttachment_False"/>
  <option name="removeUnits" value="92 Sea Zone:battleship"/>
  <option name="when" value="after:germansNonCombatMove"/>
</attachment>
<attachment name="triggerAttachment_Germany_Occupies_Southern_France_Battleship_FWA_Battleship_Neutral_Allies_Place" attachTo="Neutral_Allies" javaClass="games.strategy.triplea.attachments.TriggerAttachment" type="player">
  <option name="conditions" value="conditionAttachment_French_West_Africa_Vichy_Controlled:conditionAttachment_Fleet_Can_Turn_Neutral_Allies_Battleship:conditionAttachment_Yes_Axis_Units_In_Southern_France"/>
  <option name="placement" value="87 Sea Zone:battleship"/>
  <option name="when" value="after:germansNonCombatMove"/>
  <option name="uses" value="1"/>
  <option name="activateTrigger" value="triggerAttachment_Germany_Occupies_Southern_France_Battleship_FWA_Battleship_Remove:1:true:true:false:false"/>
</attachment>
<attachment name="conditionAttachment_Allies_Conquer_Morocco_And_Algeria" attachTo="Americans" javaClass="games.strategy.triplea.attachments.RulesAttachment" type="player">
  <option name="alliedOwnershipTerritories" value="Morocco:Algeria"/>
</attachment>
<attachment name="conditionAttachment_Allies_Occupy_French_West_Africa" attachTo="Americans" javaClass="games.strategy.triplea.attachments.RulesAttachment" type="player">
  <option name="alliedOwnershipTerritories" value="French West Africa"/>
</attachment>
<attachment name="conditionAttachment_Fleet_Can_Turn_Neutral_Allies_Battleship_French" attachTo="Neutral_Allies" javaClass="games.strategy.triplea.attachments.RulesAttachment" type="player">
  <option name="directPresenceTerritories" value="87 Sea Zone" count="1"/>
  <option name="unitPresence" value="battleship" count="1"/>
</attachment>
<attachment name="conditionAttachment_Fleet_Can_Turn_Neutral_Axis_Battleship_French" attachTo="Neutral_Axis" javaClass="games.strategy.triplea.attachments.RulesAttachment" type="player">
  <option name="directPresenceTerritories" value="87 Sea Zone" count="1"/>
  <option name="unitPresence" value="battleship" count="1"/>
</attachment>
<attachment name="conditionAttachment_French_West_Africa_Can_Turn_French_Infantry" attachTo="Neutral_Allies" javaClass="games.strategy.triplea.attachments.RulesAttachment" type="player">
  <option name="directPresenceTerritories" value="French West Africa" count="1"/>
  <option name="unitPresence" value="infantry" count="1"/>
</attachment>
<attachment name="conditionAttachment_French_West_Africa_Can_Turn_French" attachTo="French" javaClass="games.strategy.triplea.attachments.RulesAttachment" type="player">
  <option name="conditions" value="conditionAttachment_Allies_Conquer_Morocco_And_Algeria:conditionAttachment_Fleet_Can_Turn_Neutral_Allies_Battleship_French"/>
  <option name="conditionType" value="AND"/>
</attachment>
<attachment name="triggerAttachment_Allies_Occupy_French_North_Africa_Neutral_Allies_Infantry_Remove" attachTo="Neutral_Allies" javaClass="games.strategy.triplea.attachments.TriggerAttachment" type="player">
  <option name="conditions" value="conditionAttachment_False"/>
  <option name="removeUnits" value="French West Africa:infantry"/>
  <option name="when" value="after:frenchPolitics"/>
</attachment>
<attachment name="triggerAttachment_Allies_Occupy_French_North_Africa_Neutral_Allies_Infantry_Place" attachTo="French" javaClass="games.strategy.triplea.attachments.TriggerAttachment" type="player">
  <option name="conditions" value="conditionAttachment_French_West_Africa_Can_Turn_French_Infantry:conditionAttachment_French_West_Africa_Can_Turn_French"/>
  <option name="placement" value="French West Africa:infantry"/>
  <option name="when" value="after:frenchPolitics"/>
  <option name="uses" value="1"/>
  <option name="activateTrigger" value="triggerAttachment_Allies_Occupy_French_North_Africa_Neutral_Allies_Infantry_Remove:1:true:true:false:false"/>
</attachment>
<attachment name="triggerAttachment_Allies_Occupy_French_North_Africa_Neutral_Allies_Battleship_Remove" attachTo="Neutral_Allies" javaClass="games.strategy.triplea.attachments.TriggerAttachment" type="player">
  <option name="conditions" value="conditionAttachment_False"/>
  <option name="removeUnits" value="87 Sea Zone:battleship"/>
  <option name="when" value="after:frenchPolitics"/>
</attachment>
<attachment name="riggerAttachment_Allies_Occupy_French_North_Africa_Neutral_Allies_Battleship_Place" attachTo="French" javaClass="games.strategy.triplea.attachments.TriggerAttachment" type="player">
  <option name="conditions" value="conditionAttachment_French_West_Africa_Can_Turn_French"/>
  <option name="placement" value="87 Sea Zone:battleship"/>
  <option name="when" value="after:frenchPolitics"/>
  <option name="uses" value="1"/>
  <option name="activateTrigger" value="triggerAttachment_Allies_Occupy_French_North_Africa_Neutral_Allies_Battleship_Remove:1:true:true:false:false"/>
</attachment>
<attachment name="triggerAttachment_Italy_Occupies_Vichy_Southern_France_Neutral_Axis_Battleship_Remove" attachTo="Neutral_Axis" javaClass="games.strategy.triplea.attachments.TriggerAttachment" type="player">
  <option name="conditions" value="conditionAttachment_False"/>
  <option name="removeUnits" value="87 Sea Zone:battleship"/>
  <option name="when" value="after:italiansNonCombatMove"/>
</attachment>
<attachment name="riggerAttachment_Italy_Occupies_Vichy_Southern_France_Neutral_Allies_Battleship_Place" attachTo="Neutral_Allies" javaClass="games.strategy.triplea.attachments.TriggerAttachment" type="player">
  <option name="conditions" value="conditionAttachment_Yes_Axis_Units_In_Southern_France:conditionAttachment_Fleet_Can_Turn_Neutral_Axis_Battleship_French"/>
  <option name="placement" value="87 Sea Zone:battleship"/>
  <option name="when" value="after:italiansNonCombatMove"/>
  <option name="uses" value="1"/>
  <option name="activateTrigger" value="triggerAttachment_Italy_Occupies_Vichy_Southern_France_Neutral_Axis_Battleship_Remove:1:true:true:false:false"/>
</attachment>
<attachment name="triggerAttachment_Germany_Occupies_Vichy_Southern_France_Neutral_Axis_Battleship_Remove" attachTo="Neutral_Axis" javaClass="games.strategy.triplea.attachments.TriggerAttachment" type="player">
  <option name="conditions" value="conditionAttachment_False"/>
  <option name="removeUnits" value="87 Sea Zone:battleship"/>
  <option name="when" value="after:germansNonCombatMove"/>
</attachment>
<attachment name="riggerAttachment_Germany_Occupies_Vichy_Southern_France_Neutral_Allies_Battleship_Place" attachTo="Neutral_Allies" javaClass="games.strategy.triplea.attachments.TriggerAttachment" type="player">
  <option name="conditions" value="conditionAttachment_Yes_Axis_Units_In_Southern_France:conditionAttachment_Fleet_Can_Turn_Neutral_Axis_Battleship_French"/>
  <option name="placement" value="87 Sea Zone:battleship"/>
  <option name="when" value="after:germansNonCombatMove"/>
  <option name="uses" value="1"/>
  <option name="activateTrigger" value="triggerAttachment_Germany_Occupies_Vichy_Southern_France_Neutral_Axis_Battleship_Remove:1:true:true:false:false"/>
</attachment>
<attachment name="conditionAttachment_French_West_Africa_Yes_Neutral_Allies" attachTo="Neutral_Allies" javaClass="games.strategy.triplea.attachments.RulesAttachment" type="player">
  <option name="directPresenceTerritories" value="French West Africa" count="1"/>
  <option name="unitPresence" value="infantry" count="1"/>
</attachment>
<attachment name="triggerAttachment_French_West_Africa_Turns_Neutral_Allies_2" attachTo="Neutral_Allies" javaClass="games.strategy.triplea.attachments.TriggerAttachment" type="player">
  <option name="conditions" value="conditionAttachment_French_West_Africa_Yes_Neutral_Allies"/>
  <option name="when" value="after:frenchPolitics"/>
  <option name="uses" value="1"/>
  <option name="changeOwnership" value="French West Africa:Neutral_Axis:French:true"/>
  <option name="changeOwnership" value="French West Africa:French:Neutral_Allies:true"/>
</attachment>

@barnee

I tested out some of the other house rules and might have found a miss in the code.

For the 2 hit battleships and cruisers when a battleship is damaged its stats become the old battleship with single hits and 4 def roll. I think I read somewhere where someone wanted it to only do a single roll, but it looks like a miss if all of the sudden the defense value has gone up from 2 rolls of 3 to one roll of 4? Perhaps this is intended, but just pointing it out.

@waxfingers yea the Expansion 2 hit BB go to A0 D4 1 hit to kill when damaged. The code can look a little confusing as it has to jump around a bit to get the result.

Basically it’s still a 2 hit unit but starts with 1 hit of damage.

I must’ve confused with someone else. We won’t worry about Git right now. That’s it’s own challenge.

I’m thinking for now, add your stuff to the latest House Rule Mod. Make sure to document in the change log and add to the Game Notes. Also want to test that it works correctly. They’re may be an unintended error or incorrect behavior that pops up later. That isn’t uncommon and can be fixed then.

I would do one new thing per update. As long as it’s just xml changes, I think you can upload the entire xml here. That way I can just swap them out.

Also, I add a notification at game start saying what version and when uploaded but don’t do a full git/triplea notification upload right away. We’ll wait and do that when you have your first 3 ideas or so. I don’t like to spam people out too much with constant updates but you’ll still get the latest version on triplea. Just not a notification.

Are you using notepad++ ? on windows ? That’s what most do in case notepad is different or maybe you just abbreviated.

At any rate, let me know if you have trouble with anything.

Yea I’ll look for the Blue BB. Might have it or might need to have someone make one. My graphics aren’t very good lol. Yea I made em bluish for the Vichy units

@waxfingers some of your ideas will take a while. We’ll do the ones you got working first.

Also you might wanna hit the triplea site and and explain what you’re doing and there will be others that can help that know more than me.
https://forums.triplea-game.org/topic/1140/global-40-house-rules/30

@barnee

OK, so you want the huge long list of the entire game file XML from the very top to the bottom instead of inserting it yourself.

Sorry, did you mean since the French BB is good to go will that be playable on TripleA, or you want a few more updates first to let it be downloadable?

I will try out the already built in Cruiser and Battleship AA in my new games if people want and put that one aside for now.

I am just using regular Notepad which comes with Windows. I might download Notepad++ though if it makes things easier.

Since TWW has the train and rail working we just need to know how and why it works properly. When I assign the exact same properties to the rail and trains and check for properties for inf, armour, etc they all have the relevant things supposedly needed. What happens in my testing is the inf, armour, etc won’t load onto the train, and so the game thinks I am moving them simultaneously but not interacting/loaded. Thus the inf says it cannot go the full distance.

@waxfingers Right on yea most the window guys use notepad++

Yea so send the entire xml after it works right. The things like the RR, we’ll have to figure out. You might wanna ask about that at the triplea site.

I’m still committed to getting the basic and 1943 Expansion rules done, so i can’t fully help right now. I can add stuff that you already have working.

Also, idk how to update the bots at triplea, so even once it gets updated the latest version probably won’t be available for lobby play. 6.3 Expansion just got updated the other day and the old one was 4.0

@barnee

The XML is updated.
No errors thrown, all conditions and triggers tested and work properly.
Update log entry added.
Note entry added.
Rule set added.

I downloaded Notepad++ as I noticed Notepad removed some spacing.

I just tried and the game code has too many characters to post. We will need to find another way to send to you or I can try to break it up (not sure how many breaks there will be).

@barnee

115e564e-43e0-48bf-ae0c-887f9f0dba4e-Global_40_House_Rules.xml

@barnee

OK, there you go. Looks like it worked. I had to view page source to grab the XML again and it looked the same when I put it back into Notepad++. Tested and game loaded again.

Hopefully you can get it onto TripleA soon so I can start playing with it.

Thanks

@waxfingers Right on Brother ! You can still play with your version you made. And can play a Forum game with someone that has the same version. Lobby is where there will be some lag time.

I’ll send you my email in chat. I’ll try and get it updated tonight :)

Also, if you want it to work with the Canadian mod you have to double down on the xmls. I pretty much just play Canadian because I like it :) but no biggie if you don’t want it added to that one

@waxfingers Cool nice job. A couple things. At the start of the xml you need to update as well

so it says 2.677 in this case. Otherwise it’ll show up in triple as 2.676 still.

Also, I usually add the new Map options last. So I moved the French BB to be here

I don’t have the French Vichy BB. My graphic skills can’t do it, so I’ll ask at triplea for someone to do it. I don’t want to upload until we get it. It’s a visual game :)

Anyway, good job and we should have up soon. I’ll walk you through the Git thing in the future and while there’s a learning curve, it’s well worth it. Shows what was changed and allows you to just commit directly.

Looking good though.